Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation wrapmode #158

Closed
wants to merge 10 commits into from
Closed

Fix animation wrapmode #158

wants to merge 10 commits into from

Conversation

nunu-e64
Copy link
Contributor

@nunu-e64 nunu-e64 commented Apr 2, 2018

Description

Test

  • I checked animations with each wrap mode animate correctly.

minggo and others added 8 commits December 14, 2017 16:03
@minggo
fix login event
790922d
@tankorsmash @minggo
update sample resource path in README (cocos2d#139)
a040f63 
This reflects the actual path, and makes setting this up that much easier.
@minggo
fix blend issue (cocos2d#140)
351ddd6
@minggo
remove unneed file (cocos2d#143)
474cda5
@drelaptop @minggo
fix docs namespace error (cocos2d#146)
6dd75b6
@drelaptop @minggo
Add cmake files for Reader (cocos2d#149)
534a618 
* add cmake files for reader

* one more space line

* add lua file list to cmake for reader
@nunu-e64 @minggo
fix comment mistake (cocos2d#157)
6977532
@drelaptop @minggo
Fix 141, add option Export dynamically load resources (cocos2d#153)
ef95d25 
* fix Animation reverse not effect

* fix loop reverse bug

* remove a while not needed

* PingPong is a Loop mode

* add comment

* add export option

* add js logic to copy dynamic res

* improve var name

* roolback unrelated changes

* improve UI/var name
@drelaptop
Copy link
Contributor

Thanks for this patch, see PR #152 ,some of them are repeat. Could you help to review that PR? it fix a memory leak about animation (Issue #150 ) also. I'm very appreciate.

@nunu-e64 nunu-e64 force-pushed the fix-animation-wrapmode branch 2 times, most recently from 0c6fe91 to 506ed19 Compare April 3, 2018 09:21
@nunu-e64
Copy link
Contributor Author

nunu-e64 commented Apr 3, 2018 •
edited
Loading

Thank you for your review.
Indeed, It's duplicate to #152.

@nunu-e64 nunu-e64 closed this Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nunu-e64 @drelaptop @minggo @tankorsmash